David Knupp has posted comments on this change. (
http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
It's fine as is, but as a nit, an improvement might be to assert something like:
possible_errors = [
"has fewer columns (1) than the SELECT / VALUES clause returns (2)",
"(type: TINYINT) is not compatible with column 'col1' (type: STRING)",
"has fewer columns than expected.",
"Column col1 has unexpected type.",
"Client provided column col1[int64 NULLABLE] not present in tablet",
"Client provided column col1 INT64 NULLABLE not present in tablet",
"The column 'col1' must have type string NULLABLE found int64 NULLABLE"
]
# As long as one of the possible errors is in the message, assert should pass
assert any(err in msg for err in possible_errors)
http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py@448
PS1, Line 448: or "The column 'col1' must have type string NULLABLE
found int64 NULLABLE" in msg
It's fine as is, but as a nit, an improvement might be to assert something like:
possible_errors = [
"has fewer columns (1) than the SELECT / VALUES clause returns (2)",
"(type: TINYINT) is not compatible with column 'col1' (type: STRING)",
"has fewer columns than expected.",
"Column col1 has unexpected type.",
"Client provided column col1[int64 NULLABLE] not present in tablet",
"Client provided column col1 INT64 NULLABLE not present in tablet",
"The column 'col1' must have type string NULLABLE found int64 NULLABLE"
]
# As long as one of the possible errors is in the message, assert should pass
assert any(err in msg for err in possible_errors)
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:00:37 +0000
Gerrit-HasComments: Yes
