Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py@448 PS1, Line 448: "Client provided column col1 INT64 NULLABLE not present in tablet" , > It's fine as is, but as a nit, an improvement might be to assert something Done -- To view, visit http://gerrit.cloudera.org:8080/11913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2 Gerrit-Change-Number: 11913 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 08 Nov 2018 23:17:19 +0000 Gerrit-HasComments: Yes
