Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 )
Change subject: IMPALA-7842: Make query fragments available for unit testing ...................................................................... Patch Set 1: (2 comments) Structure seems fine to me. I thought about changing the return type or adding methods, but this doesn't seem worse, and is consistent with what we're already doing with explain. http://gerrit.cloudera.org:8080/#/c/11920/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11920/1/fe/src/main/java/org/apache/impala/service/Frontend.java@188 PS1, Line 188: public TQueryCtx queryCtx_; : public StringBuilder explainBuf_; : public boolean capturePlan_; : public List<PlanFragment> plan_; Are these intentionally public? http://gerrit.cloudera.org:8080/#/c/11920/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1227 PS1, Line 1227: * Create a populated TExecRequest corresponding to the supplied TQueryCtx. This should be on line 1220? There are now two public entrypoints here; document which one you expect for which purposes? -- To view, visit http://gerrit.cloudera.org:8080/11920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c615dbc1d14685a6966c5ca7538777cdc80b74d Gerrit-Change-Number: 11920 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Nov 2018 21:44:39 +0000 Gerrit-HasComments: Yes
