Fredy Wijaya has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11927


Change subject: IMPALA-941: Fix support for an identifier that starts with a 
number
......................................................................

IMPALA-941: Fix support for an identifier that starts with a number

Impala has supported an identifier that starts with a number for quite
some time. However, its implementation is broken, especially when it
comes to using it in a fully-qualified name. This patch fixes the
scanner to fix support for an idenfifier that starts with a number.
For example:

Before the fix:
> select * from 123_bar; --> this is OK
> select * from foo. 123_bar; --> this is OK
> select * from foo .123_bar; --> this is not OK
> select * from foo.123_bar; --> this is not OK

After the fix:
> select * from 123_bar; --> this is OK
> select * from foo. 123_bar; --> this is OK
> select * from foo .123_bar; --> this is OK
> select * from foo.123_bar; --> this is OK

Testing:
- Added a new parser test
- Ran all FE tests

Change-Id: I8a715be73553247ce80a1ba841712191d64f9730
---
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
2 files changed, 40 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/11927/2
--
To view, visit http://gerrit.cloudera.org:8080/11927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a715be73553247ce80a1ba841712191d64f9730
Gerrit-Change-Number: 11927
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>

Reply via email to