Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 )
Change subject: IMPALA-941: Fix support for an identifier that starts with a number ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Carry Bharath's +2. http://gerrit.cloudera.org:8080/#/c/11927/3/fe/src/main/jflex/sql-scanner.flex File fe/src/main/jflex/sql-scanner.flex: http://gerrit.cloudera.org:8080/#/c/11927/3/fe/src/main/jflex/sql-scanner.flex@414 PS3, Line 414: > ..starting with digits.. Done http://gerrit.cloudera.org:8080/#/c/11927/3/fe/src/main/jflex/sql-scanner.flex@508 PS3, Line 508: > nit:remove? Done -- To view, visit http://gerrit.cloudera.org:8080/11927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a715be73553247ce80a1ba841712191d64f9730 Gerrit-Change-Number: 11927 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Comment-Date: Wed, 14 Nov 2018 06:09:30 +0000 Gerrit-HasComments: Yes
