Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 )
Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11890/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11890/1//COMMIT_MSG@10 PS1, Line 10: Th ? http://gerrit.cloudera.org:8080/#/c/11890/1//COMMIT_MSG@26 PS1, Line 26: Added a few new tests, including some that do not pass (commented out) : to motivate the need for the refactoring. Should we add these tests separately along with the jira fixes? Not sure what is the value in including them with this commit. http://gerrit.cloudera.org:8080/#/c/11890/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/11890/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@438 PS1, Line 438: when true then 30 else 40 end", : rule, : "CASE WHEN id = 1 THEN 10 ELSE 30 END"); nit: format to fewer lines http://gerrit.cloudera.org:8080/#/c/11890/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@484 PS1, Line 484: testImpala5125 nit: more meaningful name? -- To view, visit http://gerrit.cloudera.org:8080/11890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99a28b170bc0132424041e51f61ebe5c848c4083 Gerrit-Change-Number: 11890 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 14 Nov 2018 06:02:29 +0000 Gerrit-HasComments: Yes
