Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 )
Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging ...................................................................... Patch Set 2: (4 comments) Thanks for the reviews. Addressed the comments, including removing the new (but disabled) tests. Will include those later along with the fixes that they motivated. http://gerrit.cloudera.org:8080/#/c/11890/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11890/1//COMMIT_MSG@10 PS1, Line 10: Th > ? Done http://gerrit.cloudera.org:8080/#/c/11890/1//COMMIT_MSG@26 PS1, Line 26: Testing: this is a test, ran the test to ensure it still passes. : > Should we add these tests separately along with the jira fixes? Not sure wh Sure. http://gerrit.cloudera.org:8080/#/c/11890/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: http://gerrit.cloudera.org:8080/#/c/11890/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@438 PS1, Line 438: l FALSE, return implicit NULL ELSE. : RewritesOk("decode(1, 1 + 1, id, 1 + 2, 3)", rules, "NULL"); : // Multiple TRUE, first one becomes ELSE. > nit: format to fewer lines Done http://gerrit.cloudera.org:8080/#/c/11890/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@484 PS1, Line 484: ("coalesce(1, > nit: more meaningful name? Done -- To view, visit http://gerrit.cloudera.org:8080/11890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99a28b170bc0132424041e51f61ebe5c848c4083 Gerrit-Change-Number: 11890 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Thu, 15 Nov 2018 23:41:08 +0000 Gerrit-HasComments: Yes
