Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 )
Change subject: IMPALA-6924: Add child queries to profile in compute stats ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/11977/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/11977/1/be/src/service/client-request-state.cc@563 PS1, Line 563: RuntimeProfile* child_profile = > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/11977/1/be/src/service/client-request-state.cc@568 PS1, Line 568: if (compute_stats_params.__isset.tbl_stats_query) { > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/11977/1/be/src/service/client-request-state.cc@571 PS1, Line 571: child_profile->AddChild(profile); > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/11977/1/be/src/service/client-request-state.cc@574 PS1, Line 574: } > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/11977/1/be/src/service/client-request-state.cc@577 PS1, Line 577: RuntimeProfile::Create(&profile_pool_, "Column Stats Query"); > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/11977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5006c3b366d381eed4687e550cdfc463be3d1350 Gerrit-Change-Number: 11977 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 23:16:40 +0000 Gerrit-HasComments: Yes
