Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 )
Change subject: IMPALA-6924: Add child queries to profile in compute stats ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11977/2/be/src/service/child-query.cc File be/src/service/child-query.cc: http://gerrit.cloudera.org:8080/#/c/11977/2/be/src/service/child-query.cc@104 PS2, Line 104: profile_->AddInfoString("Profile", get_profile_resp.profile); > Do we expose any way to get the actual Thrift profile with a client? I thou You're right. I think if we wanted to go that way it might be not that bad to plumb through - we could add an optional mode flag in TRuntimeProfileRequest and an optional TRuntimeProfileTree to TRuntimeProfileResponse. Or we could add a new method to ImpalaServer directly. Anyway, that's only relevant if we want to go down that path. I don't want the perfect to be the enemy of the useful here. -- To view, visit http://gerrit.cloudera.org:8080/11977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5006c3b366d381eed4687e550cdfc463be3d1350 Gerrit-Change-Number: 11977 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 01:38:22 +0000 Gerrit-HasComments: Yes
