Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11974 )
Change subject: IMPALA-5973: Provide query plan in JSON format ...................................................................... Patch Set 3: This is a continuation of https://gerrit.cloudera.org/#/c/9614/ . I'd prefer it if you re-used the Change-Id, so that we could preserve the previous comments, which still apply. I took a very very quick pass, and failed to find any examples of what this produces. I want to see some plans side by side to see what we're producing. My concern with the approach is the same as the previous review: > If the goal is machine-readability, the approach of hand-crafting JSON via > maps seems fragile. I claim that if you want machine-readability, you need to > provide the schema of your output, with a way of evolving that schema (e.g., > a version number). That is, JSON is an API, and we need to define the schema of that API explicitly. We could do this by re-using the Thrift, creating a new Thrift, using one of the several JSON schema things (https://json-schema.org/ looks like it's leading the pack, but I'm not sure), or something similar. -- To view, visit http://gerrit.cloudera.org:8080/11974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f07e2223be58b7323e1ea2fa44b62626cdf4944 Gerrit-Change-Number: 11974 Gerrit-PatchSet: 3 Gerrit-Owner: Pranay Singh (320) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 17:59:24 +0000 Gerrit-HasComments: No
