Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11974 )
Change subject: IMPALA-5973: Provide query plan in JSON format ...................................................................... Patch Set 3: Update on this one. Been working on a tricky planner bug. Ended up using the JSON serialization framework in #12079 to create a basic JSON serialization for the plan tree. Suggestion: to continue with this patch, maybe start with the 12079 serializer and the skeletal work mentioned above. Expand it to all nodes. The work I did was rough and ready: field names were chosen quickly and I serialized only what I needed. Thought is needed to figure out what to serialize and what to call it. If we serialize too close to the code, then the JSON form of the plan changes when we make trivial code changes. If we are too abstract, we loose vital details (the current EXPLAIN text, for example, omits estimated cardinality, which is rather vital.) So there would be huge value in working out the desired JSON structure, implementing serialization for all plan nodes, and wiring it up the the EXPLAIN implementation. -- To view, visit http://gerrit.cloudera.org:8080/11974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f07e2223be58b7323e1ea2fa44b62626cdf4944 Gerrit-Change-Number: 11974 Gerrit-PatchSet: 3 Gerrit-Owner: Pranay Singh (320) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Pranay Singh (320) Gerrit-Comment-Date: Thu, 27 Dec 2018 21:21:19 +0000 Gerrit-HasComments: No
