Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 )
Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11995/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11995/1//COMMIT_MSG@9 PS1, Line 9: Replaces all use of ArrayList in : variable and method declarations with the interface List. Instead of just ArrayList, why don't to go further to clean up all other collections, like Map and Set? http://gerrit.cloudera.org:8080/#/c/11995/1/fe/src/main/java/org/apache/impala/analysis/CollectionStructType.java File fe/src/main/java/org/apache/impala/analysis/CollectionStructType.java: http://gerrit.cloudera.org:8080/#/c/11995/1/fe/src/main/java/org/apache/impala/analysis/CollectionStructType.java@22 PS1, Line 22: import jline.internal.Preconditions; This is probably unintentional and should use Guava Preconditions instead. -- To view, visit http://gerrit.cloudera.org:8080/11995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c0b5f40a0504fc2d324055bd2a962e35f8e744a Gerrit-Change-Number: 11995 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 28 Nov 2018 17:46:39 +0000 Gerrit-HasComments: Yes
