Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 )
Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer ...................................................................... Patch Set 2: (2 comments) Thanks Fredy for the review. Went ahead and cleaned up the other items you suggested. Rebased on latest master. Please take another look at your convenience. Thanks! http://gerrit.cloudera.org:8080/#/c/11995/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11995/1//COMMIT_MSG@9 PS1, Line 9: Replaces all use of ArrayList : in variable and method declarations with the interface Li > Instead of just ArrayList, why don't to go further to clean up all other co Sure. More code to review, but does make sense. http://gerrit.cloudera.org:8080/#/c/11995/1/fe/src/main/java/org/apache/impala/analysis/CollectionStructType.java File fe/src/main/java/org/apache/impala/analysis/CollectionStructType.java: http://gerrit.cloudera.org:8080/#/c/11995/1/fe/src/main/java/org/apache/impala/analysis/CollectionStructType.java@22 PS1, Line 22: import org.apache.impala.catalog.Arr > This is probably unintentional and should use Guava Preconditions instead. Done -- To view, visit http://gerrit.cloudera.org:8080/11995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c0b5f40a0504fc2d324055bd2a962e35f8e744a Gerrit-Change-Number: 11995 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 23:18:26 +0000 Gerrit-HasComments: Yes
