Philip Zeyliger has posted comments on this change. (
http://gerrit.cloudera.org:8080/12005 )
Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell
commands
......................................................................
Patch Set 1:
I'm vaguely uncomfortable with the non-genericness of the solution here. If we
wanted to expose generic "unset" options, we could model that as a set<string>,
and act accordingly. I think defaulting to clearing out JAVA_TOOL_OPTIONS is
pretty sneaky. You also would need to think about shell escaping and so on (or
verifying that these are actually variables.)
In practice, maybe just change:
RunShellProcess(FLAGS_s3a_access_key_cmd, &s3a_access_key_, true)
to
RunShellProcess("unset JAVA_TOOL_OPTIONS; " + FLAGS_s3a_access_key_cmd,
&s3a_access_key_, true)
(or use string::substitute or whatever)
in the three or so places you need it?
--
To view, visit http://gerrit.cloudera.org:8080/12005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96a84a27d3bf7b02f04e70562acfd67386b93183
Gerrit-Change-Number: 12005
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Comment-Date: Wed, 28 Nov 2018 21:02:05 +0000
Gerrit-HasComments: No
