Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 )
Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/12005/3/be/src/util/os-util.cc File be/src/util/os-util.cc: http://gerrit.cloudera.org:8080/#/c/12005/3/be/src/util/os-util.cc@102 PS3, Line 102: unset_cmd += string(((i > 0) ? "; " : "")) + "unset " + env; It's a nit, but you can just do: for (...) { unset_cmd += "unset " + env + ";" } and then you don't have to worry about the "i>0" check, which makes life a little bit easier to think about. Likewise, ignore the unset_environment.size() check and just always do the substitution. -- To view, visit http://gerrit.cloudera.org:8080/12005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96a84a27d3bf7b02f04e70562acfd67386b93183 Gerrit-Change-Number: 12005 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 19:30:02 +0000 Gerrit-HasComments: Yes
