Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 )
Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test ...................................................................... Patch Set 3: Tim, thanks for the review and for pointing out the test failure. Tracked down the bug. We have a whole pile of "to sql" code in the FE, called from the BE, without unit tests. This code works with an AST without analysis, which triggered the NPE we saw earlier. The new patch includes a starter test. I'll add others in a separate patch. Please take a second look when you get a chance. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/11993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413bded920e27fe9f41f0ea989696a0c8f92fe4a Gerrit-Change-Number: 11993 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 29 Nov 2018 00:55:04 +0000 Gerrit-HasComments: No
