Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11993
to look at the new patch set (#3).
Change subject: IMPALA-7895: Incorrect expected results for
spillable-buffer-sizing.test
......................................................................
IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test
Expected results from spillable-bufe-sizing.test and max-row-size.test
included incorrect expressions: the un-anayzed GROUP BY expression with
ordinals represented as (invalid) casts.
SelectStmt is a bit of a mess. There are two copies of the grouping
expressions. Here we want to use the analyzed version with the ordinals
replaced.
Testing:
* Problem found when running PlannerTest. PlannerTest now passes,
with correct results, after this change.
* Turns out there is another path used when generating SQL for a view
which does toSql() on an unanalyzed query. Added unit tests for this
case.
Change-Id: I413bded920e27fe9f41f0ea989696a0c8f92fe4a
---
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
A fe/src/test/java/org/apache/impala/analysis/ToSqlUtilsTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test
M
testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test
4 files changed, 88 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/11993/3
--
To view, visit http://gerrit.cloudera.org:8080/11993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I413bded920e27fe9f41f0ea989696a0c8f92fe4a
Gerrit-Change-Number: 11993
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Rogers <par0...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
