Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 )
Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12005/4/be/src/util/os-util.cc File be/src/util/os-util.cc: http://gerrit.cloudera.org:8080/#/c/12005/4/be/src/util/os-util.cc@100 PS4, Line 100: for (const auto& env: unset_environment) { > unused? Done http://gerrit.cloudera.org:8080/#/c/12005/4/be/src/util/os-util.cc@103 PS4, Line 103: string new_cmd = Substitute("$0$1", unset_cmd, cmd); > unused? Done -- To view, visit http://gerrit.cloudera.org:8080/12005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96a84a27d3bf7b02f04e70562acfd67386b93183 Gerrit-Change-Number: 12005 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Thu, 29 Nov 2018 20:42:09 +0000 Gerrit-HasComments: Yes