Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 )
Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet ...................................................................... Patch Set 4: (3 comments) Thanks for taking care of my comments! There is one minor thing to sort out and then I'm fine with this change. http://gerrit.cloudera.org:8080/#/c/11984/2/be/src/exec/parquet-common.h File be/src/exec/parquet-common.h: http://gerrit.cloudera.org:8080/#/c/11984/2/be/src/exec/parquet-common.h@479 PS2, Line 479: > There is already a function with nanosecond precision, and it can create th That piece of information was missing for me. Thanks! http://gerrit.cloudera.org:8080/#/c/11984/2/be/src/exec/parquet-common.cc File be/src/exec/parquet-common.cc: http://gerrit.cloudera.org:8080/#/c/11984/2/be/src/exec/parquet-common.cc@148 PS2, Line 148: > I thought that doing it this way is the lesser evil - convert_int96_timesta Still, if you have a function to set variables based on the schema, that for me it makes sense to move everything into that function Don't see the benefit to leave the convert_int96_timestamps here. I might iss something here, though. http://gerrit.cloudera.org:8080/#/c/11984/2/be/src/exec/parquet-metadata-utils.cc File be/src/exec/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/11984/2/be/src/exec/parquet-metadata-utils.cc@71 PS2, Line 71: > Before this change the two functions were separate, but with the addition o Thanks for the explanation! -- To view, visit http://gerrit.cloudera.org:8080/11984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I932396d8646f43c0b9ca4a6359f164c4d8349d8f Gerrit-Change-Number: 11984 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sat, 01 Dec 2018 11:24:11 +0000 Gerrit-HasComments: Yes
