Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 )
Change subject: IMPALA-7842: Make query fragments available for unit testing ...................................................................... Patch Set 4: (9 comments) Refactor looks fine to me. Just some nits. http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@181 PS4, Line 181: <p> remove http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@186 PS4, Line 186: protected final TQueryCtx queryCtx_; : protected final StringBuilder explainBuf_; : protected boolean capturePlan_; : protected List<PlanFragment> plan_; Please add one-liner docs for these. http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@217 PS4, Line 217: return explainBuf_.toString(); nit: single line http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@1220 PS4, Line 1220: TQueryCtx ? http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@1221 PS4, Line 1221: This is the most general version. Populates the EXPLAIN string if : * a buffer is provided. Returns the internal plan tree if requested. : * : * Retained for legacy use. New code should use : * {@link #createExecRequest(PlanCtx)}. Not sure if this applies given the current signature change. http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@171 PS4, Line 171: nit: remove space http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java File fe/src/test/java/org/apache/impala/planner/CardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@36 PS4, Line 36: PlannerTestBase Do we need to rebase this on top of the Analysis/Query fixture changes? http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@111 PS4, Line 111: protected void verifyCardinality(String query, long expected) { method doc http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@119 PS4, Line 119: // Set up the query context. Note that we need to deep copy it before : // planning each time since planning modifies it. Not sure I got this, where is the deep copy? -- To view, visit http://gerrit.cloudera.org:8080/11920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c615dbc1d14685a6966c5ca7538777cdc80b74d Gerrit-Change-Number: 11920 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 18:56:22 +0000 Gerrit-HasComments: Yes
