Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10928 )
Change subject: IMPALA-7811: optionally count JVM heap towards process mem limit ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/10928/10/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: http://gerrit.cloudera.org:8080/#/c/10928/10/be/src/scheduling/query-schedule.h@75 PS10, Line 75: should nit: can http://gerrit.cloudera.org:8080/#/c/10928/10/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/10928/10/be/src/util/memory-metrics.cc@196 PS10, Line 196: HEAP_MAX_USAGE is it worth documenting in the header file that these correspond to the "heap" and "non-heap" pool names as populated by JniUtil.getJvmMemoryMetrics() http://gerrit.cloudera.org:8080/#/c/10928/10/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: http://gerrit.cloudera.org:8080/#/c/10928/10/common/thrift/StatestoreService.thrift@76 PS10, Line 76: admit_mem_limit we might have to change the wording on AdmissionController::REASON_REQ_OVER_NODE_MEM error message, since it refers to the process mem_limit http://gerrit.cloudera.org:8080/#/c/10928/10/tests/custom_cluster/test_jvm_mem_tracking.py File tests/custom_cluster/test_jvm_mem_tracking.py: http://gerrit.cloudera.org:8080/#/c/10928/10/tests/custom_cluster/test_jvm_mem_tracking.py@50 PS10, Line 50: GB nit: MB? -- To view, visit http://gerrit.cloudera.org:8080/10928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39dd715882a32fc986755d573bd46f0fd9eefbfc Gerrit-Change-Number: 10928 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 23:57:07 +0000 Gerrit-HasComments: Yes
