Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10928 )
Change subject: IMPALA-7811: optionally count JVM heap towards process mem limit ...................................................................... Patch Set 13: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/10928/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10928/13//COMMIT_MSG@29 PS13, Line 29: size" nit: long line http://gerrit.cloudera.org:8080/#/c/10928/10/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/10928/10/be/src/util/memory-metrics.cc@196 PS10, Line 196: HEAP_MAX_USAGE > Documented the metric names (I think using the public name is more intuitiv works for me, i was just a bit concerned since those names are populated manually in code rather than fetching it from a standard java enum/class http://gerrit.cloudera.org:8080/#/c/10928/13/tests/custom_cluster/test_jvm_mem_tracking.py File tests/custom_cluster/test_jvm_mem_tracking.py: http://gerrit.cloudera.org:8080/#/c/10928/13/tests/custom_cluster/test_jvm_mem_tracking.py@66 PS13, Line 66: e6 (feel free to ignore this comment) maybe use 100 * MB here too since thats what is mentioned in the comment above -- To view, visit http://gerrit.cloudera.org:8080/10928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39dd715882a32fc986755d573bd46f0fd9eefbfc Gerrit-Change-Number: 10928 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 00:51:37 +0000 Gerrit-HasComments: Yes
