Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 )
Change subject: IMPALA-7926: Fix flakiness in test_reconnect ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@235 PS1, Line 235: initial_impala_service.wait_for_metric_value( The default value for wait_for_metric_value() is 10 seconds. Will that be enough? http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@242 PS1, Line 242: assert get_num_open_sessions(initial_impala_service) == 0 If you change get_num_open_sessions to call wait_for_metric_value(), you can just assert here without waiting above. http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@253 PS1, Line 253: sleep(5) while you're here remove this and change get_num_open_sessions to call wait_for_metric_value instead of get_metric_value()? -- To view, visit http://gerrit.cloudera.org:8080/12045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3017ca3bf7b4e33440cffb80e9a48a63bec14434 Gerrit-Change-Number: 12045 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 23:48:52 +0000 Gerrit-HasComments: Yes
