Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 )
Change subject: IMPALA-7926: Fix flakiness in test_reconnect ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@235 PS1, Line 235: beeswax_port=21001, be_port=22001) > The default value for wait_for_metric_value() is 10 seconds. Will that be e Yes, testing locally it always takes <1s http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@242 PS1, Line 242: # Connect to localhost:21000 (default) > If you change get_num_open_sessions to call wait_for_metric_value(), you ca Done http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@253 PS1, Line 253: assert "[%s:21001] default>" % hostname in p.get_result().stdout > while you're here remove this and change get_num_open_sessions to call wait Done -- To view, visit http://gerrit.cloudera.org:8080/12045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3017ca3bf7b4e33440cffb80e9a48a63bec14434 Gerrit-Change-Number: 12045 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 19:58:34 +0000 Gerrit-HasComments: Yes
