Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 )
Change subject: IMPALA-7694: Add host resource usage metrics to profile ...................................................................... Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py File bin/plot_profile_resource_usage.py: http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@25 PS2, Line 25: d flake8: E501 line too long (162 > 90 characters) http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@29 PS2, Line 29: from thrift.protocol import TCompactProtocol flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@30 PS2, Line 30: from thrift.TSerialization import deserialize flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@31 PS2, Line 31: from RuntimeProfile.ttypes import TRuntimeProfileTree flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@33 PS2, Line 33: import argparse flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@34 PS2, Line 34: import base64 flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@35 PS2, Line 35: import datetime flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@36 PS2, Line 36: import sys flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@37 PS2, Line 37: import zlib flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@39 PS2, Line 39: import matplotlib flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@41 PS2, Line 41: import matplotlib.pyplot as plt flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/2/bin/plot_profile_resource_usage.py@43 PS2, Line 43: class ResourceUsageNotFound(Exception): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@370 PS2, Line 370: ] flake8: E124 closing bracket does not match visual indentation http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@385 PS2, Line 385: ] flake8: E124 closing bracket does not match visual indentation http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@414 PS2, Line 414: r flake8: F821 undefined name 'result' http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@432 PS2, Line 432: n flake8: E713 test for membership should be 'not in' -- To view, visit http://gerrit.cloudera.org:8080/12069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aedc20c553ab8d7ed50f72a1a936eba151487d9 Gerrit-Change-Number: 12069 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 22:35:03 +0000 Gerrit-HasComments: Yes
