Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 )
Change subject: IMPALA-7694: Add host resource usage metrics to profile ...................................................................... Patch Set 3: (17 comments) http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py File bin/plot_profile_resource_usage.py: http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@25 PS1, Line 25: d > flake8: E501 line too long (162 > 90 characters) Ignoring this for readability http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@28 PS1, Line 28: > flake8: E402 module level import not at top of file Ignoring this and the others. http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@42 PS1, Line 42: > flake8: F401 'collections.namedtuple' imported but unused Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@44 PS1, Line 44: pass > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@47 PS1, Line 47: class CountersNotFound(Exception): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@50 PS1, Line 50: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@53 PS1, Line 53: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@64 PS1, Line 64: return parser > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@80 PS1, Line 80: raise ResourceUsageNotFound("Profile does not contain resource resource usage.") > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@97 PS1, Line 97: if not per_node_counters: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@101 PS1, Line 101: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@129 PS1, Line 129: > flake8: E226 missing whitespace around arithmetic operator Done http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@148 PS1, Line 148: tree = TRuntimeProfileTree() > flake8: W391 blank line at end of file Done http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@370 PS2, Line 370: > flake8: E124 closing bracket does not match visual indentation Done http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@385 PS2, Line 385: l > flake8: E124 closing bracket does not match visual indentation Done http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@414 PS2, Line 414: > flake8: F821 undefined name 'result' Done http://gerrit.cloudera.org:8080/#/c/12069/2/tests/query_test/test_observability.py@432 PS2, Line 432: h > flake8: E713 test for membership should be 'not in' Done -- To view, visit http://gerrit.cloudera.org:8080/12069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aedc20c553ab8d7ed50f72a1a936eba151487d9 Gerrit-Change-Number: 12069 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 22:37:40 +0000 Gerrit-HasComments: Yes
