Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12091 )
Change subject: IMPALA-7963: Don't underflow uint64_t when time goes backwards ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12091/1/be/src/util/stopwatch.h File be/src/util/stopwatch.h: http://gerrit.cloudera.org:8080/#/c/12091/1/be/src/util/stopwatch.h@189 PS1, Line 189: if (end < start_) return 0; Clocks going backwards seems very concerning to me. Should we consider at least issuing a warning here? Is there a way to detect kernels that are affected? -- To view, visit http://gerrit.cloudera.org:8080/12091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa2abbbabe340b3c5f1dbec613219bc964f15747 Gerrit-Change-Number: 12091 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 17 Dec 2018 16:56:32 +0000 Gerrit-HasComments: Yes
