Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12091 )
Change subject: IMPALA-7963: Don't underflow uint64_t when time goes backwards ...................................................................... IMPALA-7963: Don't underflow uint64_t when time goes backwards Some tests on Centos 6 have shown small backwards time drifts. In this case, MonotonicStopWatch currently underflows a uint64_t and returns a very large value from RunningTime(). This changes RunningTime() to log a warning and return 0 when end < start_. Something about this changed Clang Tidy's view of the world, leading it to complain about division by zero at pretty-printer.h#L87. Switching some debug statment in webserver from using CPU_TICKS to TIME_NS fixes this issue. It is also the correct thing to do. Change-Id: Ifa2abbbabe340b3c5f1dbec613219bc964f15747 Reviewed-on: http://gerrit.cloudera.org:8080/12091 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M be/src/util/stopwatch.h M be/src/util/webserver.cc 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifa2abbbabe340b3c5f1dbec613219bc964f15747 Gerrit-Change-Number: 12091 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]>
