Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12123 )
Change subject: IMPALA-7648: add tests for OOM from scanning big string ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12123/1/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/12123/1/tests/query_test/test_insert.py@112 PS1, Line 112: ; > flake8: E703 statement ends with a semicolon adding an OOM test in test_insert can seem out of place, is there any way we can move this out? (Dont feel too strongly about moving it, since i know we need a large string to hit this) -- To view, visit http://gerrit.cloudera.org:8080/12123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d1e9b2e8cf6e167da2542950ae90717d4865e9b Gerrit-Change-Number: 12123 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 27 Dec 2018 00:01:24 +0000 Gerrit-HasComments: Yes
