Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12123 )
Change subject: IMPALA-7648: add tests for OOM from scanning big string ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12123/1/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/12123/1/tests/query_test/test_insert.py@112 PS1, Line 112: ; > flake8: E703 statement ends with a semicolon Done http://gerrit.cloudera.org:8080/#/c/12123/1/tests/query_test/test_insert.py@112 PS1, Line 112: ; > adding an OOM test in test_insert can seem out of place, is there any way w Yeah I agree that it isn't ideal but I couldn't think of anything that was enough of an improvement to justify the complexity. Probably the solution that goes most with the grain of the current test setup is to add it to the data load. But that would blow up the size of the loaded data for non-compressed file formats (which we want to test). We could avoid that by loading the data into a unique_database as part of the test, but then that would be duplicating this test anyway. -- To view, visit http://gerrit.cloudera.org:8080/12123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d1e9b2e8cf6e167da2542950ae90717d4865e9b Gerrit-Change-Number: 12123 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 27 Dec 2018 18:17:13 +0000 Gerrit-HasComments: Yes
