Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 )
Change subject: IMPALA-7902: NumericLiteral fixes, refactoring ...................................................................... Patch Set 17: (1 comment) Bharath, thanks for the reviews. Going to run another pre-review test to make sure all the rebase-related issues are resolved. Go ahead and hold off spending more time on this until that test passes. http://gerrit.cloudera.org:8080/#/c/12001/17/fe/src/main/java/org/apache/impala/analysis/Parser.java File fe/src/main/java/org/apache/impala/analysis/Parser.java: http://gerrit.cloudera.org:8080/#/c/12001/17/fe/src/main/java/org/apache/impala/analysis/Parser.java@48 PS17, Line 48: catch (AnalysisException e) { : throw e; > Trying to understand, what specific change here is propagating this Analysi Ended up removing this. The idea was that we are only interested in Parser-related errors, not semantic errors. But, as it turns out, one of the bugs fixed in this patch is a test that checks for numeric overflow in the parser and uses this function to do it. So, both parse and semantic exceptions need to be caught. Changed the catch statement accordingly. -- To view, visit http://gerrit.cloudera.org:8080/12001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I484600747b2871d3a6fe9153751973af9a8534f2 Gerrit-Change-Number: 12001 Gerrit-PatchSet: 17 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Thu, 27 Dec 2018 00:39:19 +0000 Gerrit-HasComments: Yes
