Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 )
Change subject: IMPALA-7902: NumericLiteral fixes, refactoring ...................................................................... Patch Set 18: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12001/18/fe/src/main/java/org/apache/impala/analysis/Parser.java File fe/src/main/java/org/apache/impala/analysis/Parser.java: http://gerrit.cloudera.org:8080/#/c/12001/18/fe/src/main/java/org/apache/impala/analysis/Parser.java@48 PS18, Line 48: } catch (AnalysisException e) { nit: Add a comment why we catch and throw AnalysisException here. Looks confusing when we say this throws AnalysisException above. -- To view, visit http://gerrit.cloudera.org:8080/12001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I484600747b2871d3a6fe9153751973af9a8534f2 Gerrit-Change-Number: 12001 Gerrit-PatchSet: 18 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Dec 2018 18:55:27 +0000 Gerrit-HasComments: Yes
