Hello Bharath Vissapragada, Paul Rogers, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12125
to look at the new patch set (#4).
Change subject: IMPALA-8016: Fix lifecycle of classloader for UDFs.
......................................................................
IMPALA-8016: Fix lifecycle of classloader for UDFs.
The ClassLoader whence a UDF was loaded needs to be kept open for
executions of the UDF, so that the UDF can load other classes from the
same jar. (A typical scenario might be a utility class.) This was
broken by the fix to IMPALA-7668.
This commit moves closing the ClassLoader to the close() function.
A test for a UDF that imports a static method from another file has been
added. Doing so failed without this change.
Change-Id: Ic02e42fb25a2754ede21fe00312a60f07e0ba8a2
---
M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java
M testdata/workloads/functional-query/queries/QueryTest/java-udf.test
M testdata/workloads/functional-query/queries/QueryTest/load-java-udfs.test
A
tests/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java
A tests/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdf.java
5 files changed, 103 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/12125/4
--
To view, visit http://gerrit.cloudera.org:8080/12125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic02e42fb25a2754ede21fe00312a60f07e0ba8a2
Gerrit-Change-Number: 12125
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Paul Rogers <[email protected]>
