Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12125 )
Change subject: IMPALA-8016: Fix lifecycle of classloader for UDFs. ...................................................................... IMPALA-8016: Fix lifecycle of classloader for UDFs. The ClassLoader whence a UDF was loaded needs to be kept open for executions of the UDF, so that the UDF can load other classes from the same jar. (A typical scenario might be a utility class.) This was broken by the fix to IMPALA-7668. This commit moves closing the ClassLoader to the close() function. A test for a UDF that imports a static method from another file has been added. Doing so failed without this change. Change-Id: Ic02e42fb25a2754ede21fe00312a60f07e0ba8a2 Reviewed-on: http://gerrit.cloudera.org:8080/12125 Reviewed-by: Philip Zeyliger <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java M testdata/workloads/functional-query/queries/QueryTest/java-udf.test M testdata/workloads/functional-query/queries/QueryTest/load-java-udfs.test A tests/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java A tests/test-hive-udfs/src/main/java/org/apache/impala/UtilForUdf.java 5 files changed, 103 insertions(+), 20 deletions(-) Approvals: Philip Zeyliger: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic02e42fb25a2754ede21fe00312a60f07e0ba8a2 Gerrit-Change-Number: 12125 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]>
