Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12130 )
Change subject: IMPALA-7666: Adding an opaque client identifier to query options. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12130/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12130/2//COMMIT_MSG@15 PS2, Line 15: protoype *prototype Are you going to include that in this patch? That would be cool. Alternatively it might be nice to include a proof-of-concept in impala-shell too. http://gerrit.cloudera.org:8080/#/c/12130/2/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12130/2/be/src/service/query-options.cc@724 PS2, Line 724: .c_str() Can't we just pass the original string? -- To view, visit http://gerrit.cloudera.org:8080/12130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a7708492f05d33b2bc99fc3a03b461bbb6f3ea4 Gerrit-Change-Number: 12130 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Jan 2019 18:39:45 +0000 Gerrit-HasComments: Yes
