Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12130 )

Change subject: IMPALA-7666: Adding an opaque client identifier to query 
options.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12130/3/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/12130/3/be/src/service/query-options.cc@723
PS3, Line 723:
> nit: space
Done


http://gerrit.cloudera.org:8080/#/c/12130/3/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/12130/3/shell/impala_shell.py@1632
PS3, Line 1632:   # support this config option, though a warning is produced.
> I feel like using a newer client to connect to an older impala daemon might
I moved this around.No more warning.



--
To view, visit http://gerrit.cloudera.org:8080/12130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7708492f05d33b2bc99fc3a03b461bbb6f3ea4
Gerrit-Change-Number: 12130
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 09 Jan 2019 19:02:05 +0000
Gerrit-HasComments: Yes

Reply via email to