Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 )
Change subject: IMPALA-7924: Generate Thrift 11 Python Code ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12036/2/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12036/2/common/thrift/CMakeLists.txt@a230 PS2, Line 230: > Did you mean to remove this as a dependency? thrift-deps depends on thrift11-py, which depends on thrift-ext-data-src. My understanding is thats its basically a chain of dependencies, so the intention was to just add thrift11-py as a node in that chain. But I might be missing something, pretty new to CMake :) -- To view, visit http://gerrit.cloudera.org:8080/12036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3432c3e29d28ec3ef6a0a22156a18910f511fed0 Gerrit-Change-Number: 12036 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Jan 2019 18:12:12 +0000 Gerrit-HasComments: Yes