Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 )
Change subject: IMPALA-7924: Generate Thrift 11 Python Code ...................................................................... Patch Set 2: (2 comments) LGTM, just one ask about the commit message then I can start GVD http://gerrit.cloudera.org:8080/#/c/12036/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12036/2//COMMIT_MSG@13 PS2, Line 13: The Thrift 11 Python deserialization code has some big performance Might be worth briefly mentioning how to take advantage of it - does one just set PYTHONPATH to include it manually? http://gerrit.cloudera.org:8080/#/c/12036/2/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12036/2/common/thrift/CMakeLists.txt@a230 PS2, Line 230: > thrift-deps depends on thrift11-py, which depends on thrift-ext-data-src. M Ah I missed that. I suppose that works. -- To view, visit http://gerrit.cloudera.org:8080/12036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3432c3e29d28ec3ef6a0a22156a18910f511fed0 Gerrit-Change-Number: 12036 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Jan 2019 18:22:31 +0000 Gerrit-HasComments: Yes
