Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 )
Change subject: IMPALA-6664: Tag log statements with fragment or query ids. ...................................................................... Patch Set 2: (4 comments) Please take another look! http://gerrit.cloudera.org:8080/#/c/12129/1/be/src/common/logging.cc File be/src/common/logging.cc: http://gerrit.cloudera.org:8080/#/c/12129/1/be/src/common/logging.cc@55 PS1, Line 55: const TUniqueId kZeroUniqueId; > Nice. I think the next step would be to (re)define VLOG_QUERY or something > like it, that would be called for debug logging in the query/FINST lifecycle > code? With the updated change, this is pretty much done. There may be threads (like krpc sender) that don't know or haven't annotated what query they're working on, but this captures a good chunk of it. http://gerrit.cloudera.org:8080/#/c/12129/1/be/src/common/logging.cc@55 PS1, Line 55: Uniqu > std:: not needed Done http://gerrit.cloudera.org:8080/#/c/12129/1/be/src/common/logging.cc@65 PS1, Line 65: } > The API chosen is a little unfortunate since it requires reallocating 's' t Indeed. Todd probably says we should use async_logger. If we have an opinion on that, that would be a good opportunity to figure out if we want to make this interface better. In practice, though, we've not seen this show up in profiling, so I'm ignoring it for now. http://gerrit.cloudera.org:8080/#/c/12129/1/be/src/common/logging.cc@68 PS1, Line 68: ue; > same here Done -- To view, visit http://gerrit.cloudera.org:8080/12129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6634ef9d1a7346339f24f2d40a7a3aa36a535da8 Gerrit-Change-Number: 12129 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 08 Jan 2019 19:10:47 +0000 Gerrit-HasComments: Yes
