Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 )
Change subject: IMPALA-6664: Tag log statements with fragment or query ids. ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12129/2/be/src/runtime/io/request-context.h File be/src/runtime/io/request-context.h: http://gerrit.cloudera.org:8080/#/c/12129/2/be/src/runtime/io/request-context.h@403 PS2, Line 403: TUniqueId instance_id_; > I didn't do this because I don't think a request-context could be working n Yeah that is true. I think if it's an invariant that they're always set we should just pass them in via RegisterContext/the constructor. http://gerrit.cloudera.org:8080/#/c/12129/3/tests/observability/test_log_fragments.py File tests/observability/test_log_fragments.py: http://gerrit.cloudera.org:8080/#/c/12129/3/tests/observability/test_log_fragments.py@26 PS3, Line 26: def test_log_framgnets(self): typo:fragments http://gerrit.cloudera.org:8080/#/c/12129/3/tests/observability/test_log_fragments.py@34 PS3, Line 34: profile nit: result (since it's not a profile, rather an ImpalaBeeswaxResult) -- To view, visit http://gerrit.cloudera.org:8080/12129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6634ef9d1a7346339f24f2d40a7a3aa36a535da8 Gerrit-Change-Number: 12129 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 19:59:33 +0000 Gerrit-HasComments: Yes
