Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 )
Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/11575/16/tests/util/counters.py File tests/util/counters.py: http://gerrit.cloudera.org:8080/#/c/11575/16/tests/util/counters.py@19 PS16, Line 19: class SummaryStatsCounter(object): > Yeah, looks like the backend tests use the text profile in many places and I changed it to use TSummaryStatsCounter. Flake8 doesn't seem to like using named lambdas (https://stackoverflow.com/questions/25010167/e731-do-not-assign-a-lambda-expression-use-a-def), so I just defined a helper function in test_scanners. -- To view, visit http://gerrit.cloudera.org:8080/11575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322f9b324b6828df28e5caf79529085c43d7c817 Gerrit-Change-Number: 11575 Gerrit-PatchSet: 16 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 10 Jan 2019 15:39:08 +0000 Gerrit-HasComments: Yes
