Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 )
Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ...................................................................... Patch Set 19: (3 comments) This looks good. Had a few style things but will +2 once they are fixed. http://gerrit.cloudera.org:8080/#/c/11575/19/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/11575/19/be/src/exec/hdfs-scan-node-base.cc@955 PS19, Line 955: const int64_t& uncompressed_bytes_read, const int64_t& compressed_bytes_read) { It doesn't make sense to pass in a const reference to an integer since the pointer is 64 bits and the value is 64 bits - just pass it by value. Passing const ref is mainly an optimisation to avoid passing a large data structure by value. http://gerrit.cloudera.org:8080/#/c/11575/19/be/src/exec/hdfs-scan-node-base.cc@968 PS19, Line 968: boost::lock_guard<boost::shared_mutex> bytes_read_per_col_guard_write_lock( nit: boost:: prefix shouldn't be necessarily because we import into the namespace in common/names.h http://gerrit.cloudera.org:8080/#/c/11575/19/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11575/19/tests/query_test/test_scanners.py@827 PS19, Line 827: assert(len(compressed_page_size_summaries) > 0) nit: python assert doesn't require parens for argument -- To view, visit http://gerrit.cloudera.org:8080/11575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322f9b324b6828df28e5caf79529085c43d7c817 Gerrit-Change-Number: 11575 Gerrit-PatchSet: 19 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 15 Jan 2019 21:20:36 +0000 Gerrit-HasComments: Yes
