Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12095 )
Change subject: IMPALA-7986,IMPALA-7987: run daemons in docker containers ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/12095/11/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/12095/11/bin/impala-config.sh@275 PS11, Line 275: export EXTERNAL_LISTEN_HOST="${EXTERNAL_LISTEN_HOST-0.0.0.0}" > This should be 0.0.0.0 by default. Done http://gerrit.cloudera.org:8080/#/c/12095/11/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/12095/11/bin/start-impala-cluster.py@244 PS11, Line 244: result = ["-logbufsecs=5", "-v={0}".format(options.log_level), > I accidentally removed the -, which makes the argument ineffective. This sh Done http://gerrit.cloudera.org:8080/#/c/12095/13/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/12095/13/bin/start-impala-cluster.py@499 PS13, Line 499: LOG.info("Stopping container {0}".format(container_name)) : check_call(["docker", "stop", container_name]) > Could you add a comment explaining why we stop the impalad docker container Oh right, that's a mistake. I intended to always destroy containers. Thinking about it, maybe it makes sense to just stop containers so that it's possible to manually restart them, recover logs, etc. IIRC I went down the path of destroying them because only stopping them prevented creating a new container with the same name, but __run_container__() handles that anyway. -- To view, visit http://gerrit.cloudera.org:8080/12095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5975cced33fa93df43101dd47d19b8af12e93d11 Gerrit-Change-Number: 12095 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 11 Jan 2019 19:48:01 +0000 Gerrit-HasComments: Yes
