Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12095 )
Change subject: IMPALA-7986,IMPALA-7987: run daemons in docker containers ...................................................................... Patch Set 13: Code-Review+1 This looks good to me. At some point, we'll need to grapple with getting logs out and when to stop vs destroy, but this is moving quickly and that can be addressed in a future code change. I'm basically good with bumping this up to a +2. You'll need to refresh to get past IMPALA-8066. -- To view, visit http://gerrit.cloudera.org:8080/12095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5975cced33fa93df43101dd47d19b8af12e93d11 Gerrit-Change-Number: 12095 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 Jan 2019 00:31:47 +0000 Gerrit-HasComments: No
