Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 )
Change subject: IMPALA-7941: part 1: detect cgroups memory limit ...................................................................... Patch Set 9: (1 comment) Any chance to look at my question? http://gerrit.cloudera.org:8080/#/c/12120/7/be/src/util/cgroup-util.cc File be/src/util/cgroup-util.cc: http://gerrit.cloudera.org:8080/#/c/12120/7/be/src/util/cgroup-util.cc@86 PS7, Line 86: split(fields, line, is_any_of(" "), token_compress_on); > i was curious as to how this will work if the mount point had spaces in it. That's a good point. I guess this won't work correctly in that case since we're not decon -- To view, visit http://gerrit.cloudera.org:8080/12120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0f5ed0e94511361bf5605822c0874c16c45ffa9 Gerrit-Change-Number: 12120 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 Jan 2019 01:46:12 +0000 Gerrit-HasComments: Yes
