Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 )
Change subject: IMPALA-7941: part 1: detect cgroups memory limit ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/12120/7/be/src/util/cgroup-util.cc File be/src/util/cgroup-util.cc: http://gerrit.cloudera.org:8080/#/c/12120/7/be/src/util/cgroup-util.cc@86 PS7, Line 86: split(fields, line, is_any_of(" "), token_compress_on); > Can you send me a pointer to the info you found about this? It seems like w https://superuser.com/a/527503 I tried this out myself by running: sudo mount /dev/sda3 /home/user/mnt\ check/ then checked output of mountinfo: "more /proc/self/mountinfo" output: 305 29 8:3 / /home/user/mnt\040check rw,relatime shared:137 - ext4 /dev/sda3 rw,data=ordered http://gerrit.cloudera.org:8080/#/c/12120/7/be/src/util/cgroup-util.cc@86 PS7, Line 86: split(fields, line, is_any_of(" "), token_compress_on); > That's a good point. I guess this won't work correctly in that case since w You are right, it wont work correctly in that case, we will have to decode the escape characters since they would be written down in octal but wont be accepted as a valid file name when trying to read it -- To view, visit http://gerrit.cloudera.org:8080/12120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0f5ed0e94511361bf5605822c0874c16c45ffa9 Gerrit-Change-Number: 12120 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 Jan 2019 02:32:03 +0000 Gerrit-HasComments: Yes
