Thomas Marshall has posted comments on this change. (
http://gerrit.cloudera.org:8080/12226 )
Change subject: IMPALA-7800: Reject new connections after --fe_service_threads
......................................................................
Patch Set 6:
> (5 comments)
>
> The historical tidbit that struck my interests is the following:
>
> * This helps solve IMPALA-4135, where connections were timing out
> while waiting in the
> * OS accept queue, by ensuring that accept() is called as quickly
> as possible.
> */
> class TAcceptQueueServer : public TServer {
>
> So, at some point in the past, users, when connecting to a busy
> impala, would hit a timeout.
> (5 comments)
>
> The historical tidbit that struck my interests is the following:
>
> * This helps solve IMPALA-4135, where connections were timing out
> while waiting in the
> * OS accept queue, by ensuring that accept() is called as quickly
> as possible.
> */
> class TAcceptQueueServer : public TServer {
>
> So, at some point in the past, users, when connecting to a busy
> impala, would hit a timeout.
For some more context, IMPALA-4135 was addressing an issue where backend
connections would time out (in particular, due to queries that contained a
large number of fragments), I don't think we particularly considered the impact
on client connections.
Now that we're transitioning the backend connections to krpc, the original
motivation for TAcceptQueueServer is becoming obsolete
--
To view, visit http://gerrit.cloudera.org:8080/12226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9d48aaff9e3b5854b5121798211c641c58a559
Gerrit-Change-Number: 12226
Gerrit-PatchSet: 6
Gerrit-Owner: Zoram Thanga <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Thomas Marshall <[email protected]>
Gerrit-Comment-Date: Mon, 21 Jan 2019 20:27:16 +0000
Gerrit-HasComments: No
