Zoram Thanga has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12579 )

Change subject: IMPALA-7800: Reject new connections after --fe_service_threads
......................................................................


Patch Set 2:

(11 comments)

Fixed

http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py
File tests/custom_cluster/test_frontend_connection_limit.py:

http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@19
PS2, Line 19: import sys
> flake8: F401 'sys' imported but unused
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@23
PS2, Line 23: from getpass import getuser
> flake8: F401 'getpass.getuser' imported but unused
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@64
PS2, Line 64:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@64
PS2, Line 64:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@64
PS2, Line 64:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@64
PS2, Line 64:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@65
PS2, Line 65:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@65
PS2, Line 65:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@65
PS2, Line 65:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@65
PS2, Line 65:
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/12579/2/tests/custom_cluster/test_frontend_connection_limit.py@91
PS2, Line 91:
> flake8: E261 at least two spaces before inline comment
Done



--
To view, visit http://gerrit.cloudera.org:8080/12579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb345c1d84cc2f691f54ded467f253e758f87e64
Gerrit-Change-Number: 12579
Gerrit-PatchSet: 2
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:39:27 +0000
Gerrit-HasComments: Yes

Reply via email to