Hello Zoltan Borok-Nagy,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12238
to look at the new patch set (#3).
Change subject: IMPALA-8090: race when reusing ScanRange in test
......................................................................
IMPALA-8090: race when reusing ScanRange in test
The issue occurs in test code where two reads are issued
with the same ScanRange object back-to-back, e.g. in
SyncReadTest. The DiskIoMgr enqueues the last buffer
or cancels the scan range *before* closing the
'file_reader_', which means that the client thread
thinks the ScanRange is done and can re-enqueue
it into the DiskIoMgr.
This is not an issue in Impala itself because scan
ranges are not reused in this fashion.
I evaluated adding a DCHECK but the lifecycle
of the ScanRange objects is complicated enough
that there wasn't a straightforward invariant
to enforce.
Testing:
Looped the previously-failing test overnight.
Change-Id: I3122e5b2efea60ffe82d780930301d5be108876b
---
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
2 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/12238/3
--
To view, visit http://gerrit.cloudera.org:8080/12238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3122e5b2efea60ffe82d780930301d5be108876b
Gerrit-Change-Number: 12238
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
