Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 )
Change subject: IMPALA-7941: part 2/2: use cgroups memory limit ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12262/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/12262/1/bin/start-impala-cluster.py@298 PS1, Line 298: .format(compute_impalad_mem_limit(cluster_size) Need to remove this .format(), it's a noop http://gerrit.cloudera.org:8080/#/c/12262/1/bin/start-impala-cluster.py@497 PS1, Line 497: mem_limit = compute_impalad_mem_limit(cluster_size) Can move this outside loop http://gerrit.cloudera.org:8080/#/c/12262/1/bin/start-impala-cluster.py@535 PS1, Line 535: # TODO: docker memory limit remove -- To view, visit http://gerrit.cloudera.org:8080/12262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fb4fb936a46fc194a204391d03c07c8c7fba21 Gerrit-Change-Number: 12262 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 24 Jan 2019 00:55:15 +0000 Gerrit-HasComments: Yes
